replace PyString::from_object with PyString::from_encoded_object#5017
Merged
davidhewitt merged 6 commits intoPyO3:mainfrom Aug 1, 2025
Merged
replace PyString::from_object with PyString::from_encoded_object#5017davidhewitt merged 6 commits intoPyO3:mainfrom
PyString::from_object with PyString::from_encoded_object#5017davidhewitt merged 6 commits intoPyO3:mainfrom
Conversation
davidhewitt
force-pushed
the
deprecate-string-from-object
branch
3 times, most recently
from
ec502ec to
5de3f93
Compare
Member
Author
|
Looks like adding a deprecation is discouraged in a patch, so will keep this for 0.25. Think we'll start merging all those changes in shortly, I just want to get 0.24.1 done first. |
Member
Author
|
With #5021 prepped, I think this is ready for merge, if others agree this is a good idea? |
Icxolu
reviewed
Mar 28, 2025
Closed
davidhewitt
force-pushed
the
deprecate-string-from-object
branch
from
525f5af to
4d87463
Compare
Icxolu
approved these changes
Jul 25, 2025
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #5008, as per my suggestion in #5005