Reject generics explicitly for #[pyclass]#503
Merged
kngwyu merged 1 commit intoPyO3:masterfrom Jun 6, 2019
Merged
Conversation
konstin
approved these changes
Jun 5, 2019
Member
konstin
left a comment
konstin
left a comment
There was a problem hiding this comment.
Using trybuild is really cool! The code changes look good, but we need to fix ci in some way before merging this.
Member
Author
|
I tried |
Member
Author
|
Now appveyor fails... 😢 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per the discussion in #502, I tried to improve the error message for pyclasses with generic parameters.
In this PR, I also introduced the use of trybuild, which is a great library to test compile error messages for proc-macro functions.