Merged
Conversation
bschoenmaeckers
force-pushed
the
tzinfo-constructors
branch
6 times, most recently
from
675314d to
21856f1
Compare
Icxolu
reviewed
Apr 14, 2025
bschoenmaeckers
force-pushed
the
tzinfo-constructors
branch
2 times, most recently
from
966baa9 to
d881f84
Compare
bschoenmaeckers
force-pushed
the
tzinfo-constructors
branch
2 times, most recently
from
19b821b to
1bb5288
Compare
bschoenmaeckers
force-pushed
the
tzinfo-constructors
branch
from
1bb5288 to
4f34767
Compare
Icxolu
approved these changes
Apr 15, 2025
Member
Icxolu
left a comment
Icxolu
left a comment
There was a problem hiding this comment.
LGTM
@davidhewitt Any concerns from your side?
davidhewitt
approved these changes
Apr 25, 2025
Member
davidhewitt
left a comment
davidhewitt
left a comment
There was a problem hiding this comment.
Looks good to me, thanks 👍
newcomertv
pushed a commit
to newcomertv/pyo3
that referenced
this pull request
Apr 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This continuous the discussion if we want additional constructors for
PyTzInfo, started in #4970. By doing so it enables users to easily create timezone aware datetimes without going trough chrono-tz or jiff integrations.