Skip to content

ci: fix clippy jobs only running Python 3.7 checks#5090

Merged
davidhewitt merged 2 commits intoPyO3:mainfrom
davidhewitt:fix-feature-sets
Apr 25, 2025
Merged

ci: fix clippy jobs only running Python 3.7 checks#5090
davidhewitt merged 2 commits intoPyO3:mainfrom
davidhewitt:fix-feature-sets

Conversation

@davidhewitt
Copy link
Copy Markdown
Member

Broken since #4823

lru_cache caching a generator will mean that the feature sets can only be consumed once.

This unfortunately makes CI slower because we were accidentally not running full clippy work. Will have a think if there's anything that can be done about that 😢

@davidhewitt davidhewitt added the CI-no-fail-fast If one job fails, allow the rest to keep testing label Apr 25, 2025
@davidhewitt davidhewitt enabled auto-merge April 25, 2025 12:39
@davidhewitt davidhewitt added this pull request to the merge queue Apr 25, 2025
Merged via the queue into PyO3:main with commit a95eecd Apr 25, 2025
43 of 44 checks passed
@davidhewitt davidhewitt deleted the fix-feature-sets branch April 25, 2025 13:38
newcomertv pushed a commit to newcomertv/pyo3 that referenced this pull request Apr 28, 2025
* ci: fix clippy jobs only running Python 3.7 checks

* pass correct config file for 3.13t
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-no-fail-fast If one job fails, allow the rest to keep testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant