fix jiff::Zoned into python conversion when zoneinfo is not available#5120
Merged
davidhewitt merged 2 commits intoPyO3:mainfrom May 9, 2025
Merged
fix jiff::Zoned into python conversion when zoneinfo is not available#5120davidhewitt merged 2 commits intoPyO3:mainfrom
jiff::Zoned into python conversion when zoneinfo is not available#5120davidhewitt merged 2 commits intoPyO3:mainfrom
Conversation
bschoenmaeckers
force-pushed
the
jiff-no-zoneinfo
branch
from
d97f39e to
1d34f0a
Compare
Member
|
Thanks! To avoid the difference in behaviour across Python versions, I wonder if it would be better to try to use |
Member
Author
Interesting idea! Added the fallback in the latest commit. Please let me know what you think. |
bschoenmaeckers
force-pushed
the
jiff-no-zoneinfo
branch
from
e77f8b4 to
1f60ffa
Compare
bschoenmaeckers
force-pushed
the
jiff-no-zoneinfo
branch
from
1f60ffa to
fed5030
Compare
davidhewitt
approved these changes
May 9, 2025
Member
davidhewitt
left a comment
davidhewitt
left a comment
There was a problem hiding this comment.
Thanks, I think this is an elegant fallback 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will fix the doctest on python 3.7/3.8 seen in #5091.