fix possibly leaked borow in PyRef::into_super#5253
Closed
Conversation
davidhewitt
reviewed
Jul 23, 2025
Member
davidhewitt
left a comment
davidhewitt
left a comment
There was a problem hiding this comment.
Thanks - and uh oh I think I see another case 🙃
| /// ``` | ||
| pub fn into_super(self) -> PyRef<'p, U> { | ||
| let py = self.py(); | ||
| if <U::Frozen as crate::pyclass::boolean_struct::private::Boolean>::VALUE { |
Member
There was a problem hiding this comment.
Checking the constant value is a neat solution.
Crazy question though, what if U is itself a child of another type V which is not frozen?
Then I think the borrow flag is owned by V and it would be incorrect to release here 🙈
Member
Author
There was a problem hiding this comment.
Right... And If we have something like
Base (frozen) -> S1(mut) -> S2(frozen) -> S3(mut)
The counter is owned by S1 I think, so S3 -> S2 should keep it, while S1 -> Base should release it 😭
I feel like this needs to be solved in the borrow checker itself and cant be worked around here... 😞
Member
Author
|
Superseeded by #5281 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref #5233 (comment)