use custom error type in pyclass extraction#5413
Merged
Conversation
Icxolu
force-pushed
the
pyclass-extract-error
branch
from
686b39f to
77a517b
Compare
davidhewitt
approved these changes
Sep 7, 2025
Member
davidhewitt
left a comment
davidhewitt
left a comment
There was a problem hiding this comment.
Thanks, this looks good to me 👍
I think for the moment keeping the type opaque is correct, I'm unsure how solving #5412 may impact the complexity of these errors.
Icxolu
force-pushed
the
pyclass-extract-error
branch
from
77a517b to
7c03db7
Compare
Member
Author
|
Great, I've added the changelog. |
tpoliaw
added a commit
to tpoliaw/pyo3
that referenced
this pull request
Nov 4, 2025
Path::into_pyobject now returns a pathlib.Path object which doesn't work as expected when added to sys.path so revert to string (see PyO3#4925). `impl FromPyObject for PyRefMut` now returns a custom error type (that doesn't impl `std::error::Error`) so map the error back the PyErr to return it (see PyO3#5413).
tpoliaw
added a commit
to tpoliaw/pyo3
that referenced
this pull request
Nov 4, 2025
Path::into_pyobject now returns a pathlib.Path object which doesn't work as expected when added to sys.path so revert to string (see PyO3#4925). `impl FromPyObject for PyRefMut` now returns a custom error type (that doesn't impl `std::error::Error`) so map the error back the PyErr to return it (see PyO3#5413).
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 8, 2025
Path::into_pyobject now returns a pathlib.Path object which doesn't work as expected when added to sys.path so revert to string (see #4925). `impl FromPyObject for PyRefMut` now returns a custom error type (that doesn't impl `std::error::Error`) so map the error back the PyErr to return it (see #5413).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the idea sketched out in #5391 (comment)