Skip to content

bump supported graalpy to v25.0#5542

Merged
bschoenmaeckers merged 4 commits intoPyO3:mainfrom
bazaah:feat/graalpy-v25
Oct 20, 2025
Merged

bump supported graalpy to v25.0#5542
bschoenmaeckers merged 4 commits intoPyO3:mainfrom
bazaah:feat/graalpy-v25

Conversation

@bazaah
Copy link
Contributor

@bazaah bazaah commented Oct 20, 2025

Description

Bump GraalPY support to v25, the first version that supports the new PEP-489 multi-phase initialization functions we need in #5525.

@bazaah bazaah changed the title github/workflows: bump CI graalpy to v25.0 bump supported graalpy to v25.0 Oct 20, 2025
@ngoldbaum
Copy link
Contributor

ngoldbaum commented Oct 20, 2025

Judging by #5116 this is probably going to need some munging with tests to get the graalpy build to succeed. Unless you tested locally and that wasn't necessary.

I added the "full" CI label to the graalpy tests fire on the PR.

@ngoldbaum ngoldbaum added the CI-no-fail-fast If one job fails, allow the rest to keep testing label Oct 20, 2025
@bazaah
Copy link
Contributor Author

bazaah commented Oct 20, 2025

I haven't yet -- thanks I was hoping to see what would fail in CI then go fix it from there

@LilyFirefly LilyFirefly disabled auto-merge October 20, 2025 16:45
@davidhewitt
Copy link
Member

Will need to push again to trigger a full run

@LilyFirefly LilyFirefly added this pull request to the merge queue Oct 20, 2025
@bschoenmaeckers bschoenmaeckers removed this pull request from the merge queue due to a manual request Oct 20, 2025
Copy link
Member

@bschoenmaeckers bschoenmaeckers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should also bump ‎MINIMUM_SUPPORTED_VERSION_GRAALPY in pyo3-build-config.

Copy link
Member

@bschoenmaeckers bschoenmaeckers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great tnx!

@bschoenmaeckers bschoenmaeckers added this pull request to the merge queue Oct 20, 2025
Merged via the queue into PyO3:main with commit 6b8b1c1 Oct 20, 2025
85 checks passed
@bazaah bazaah deleted the feat/graalpy-v25 branch October 21, 2025 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-build-full CI-no-fail-fast If one job fails, allow the rest to keep testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants