-
Notifications
You must be signed in to change notification settings - Fork 958
Use PyModExport and PyABIInfo APIs in pymodule implementation #5753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
929187d
Use PyModExport and PyABIInfo APIs in pymodule implementation
ngoldbaum 951901f
Add PyModExport function
ngoldbaum ffc8c9f
DNM: temporarily disable append_to_inittab doctest
ngoldbaum 3aef886
fix issues seen on older pythons in CI
ngoldbaum 2dfa5a6
fix incorrect ModuleDef setup on 3.15
ngoldbaum 6481f24
Expose both the PyInit and PyModExport initialization hooks
ngoldbaum b9ca761
fix clippy
ngoldbaum d807872
add changelog entry
ngoldbaum 1b07bef
avoid unnecessary extra quote! use
ngoldbaum 9491557
rename MAX_SLOTS as MAX_SLOTS_WITH_TRAILING_NULL
ngoldbaum bd67e96
Move MAX_SLOTS check to push
ngoldbaum 07be9c8
Apply David's suggestions for tests
ngoldbaum ffff4bb
Always include abi info slot in PyModule initialization
ngoldbaum 2aeff6d
only unwind panics if panic = "unwind"
ngoldbaum b637563
appease clippy
ngoldbaum 92afcb1
try use only slots for both init hooks on 3.15
ngoldbaum e5f3c0b
Always pass m_name and m_doc, following cpython-gh-144340
ngoldbaum 93ecb4a
fix conditional compilation
ngoldbaum 78b169c
fix ffi-check in 3.15.0a7
ngoldbaum 01572c3
Merge branch 'main' into moduledef-hide-details
ngoldbaum File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Module initialization uses the PyModExport and PyABIInfo APIs on python 3.15 and newer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.