Conversation
Contributor
|
PyO3's cargo tests fully pass when I merge in this branch to my This is with the GIL-enabled build. The free-threaded build will take more work. Still - pretty awesome that PyO3 can generate extensions that don't depend on the definition of PyObject on 3.15! I'm tempted to hit the merge button but given that @Icxolu has been looking at this code recently I'd like them to take a look first. |
ngoldbaum
approved these changes
Feb 17, 2026
Icxolu
approved these changes
Feb 17, 2026
Member
Icxolu
left a comment
Icxolu
left a comment
There was a problem hiding this comment.
LGTM as well. Thanks for finding the root cause!
davidhewitt
added a commit
that referenced
this pull request
Feb 17, 2026
…3` + 3.12 subclassing of native types) (#5823) * add test for subclassing variable-sized type * fix type confusion inside `get_contents_of_obj` * newsfragment
Merged
davidhewitt
added a commit
that referenced
this pull request
Feb 18, 2026
…3` + 3.12 subclassing of native types) (#5823) * add test for subclassing variable-sized type * fix type confusion inside `get_contents_of_obj` * newsfragment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the problem observed in #5807 (comment)
Once we have this merged, we should probably look at releasing 0.28.2 with this fix, given it's memory corruption.