Remove unsound return of borrowed objects#890
Merged
kngwyu merged 2 commits intoPyO3:masterfrom May 4, 2020
Merged
Conversation
Merged
Member
Author
|
In case we're worried about performance regressions, I made some benchmarks (from #891). I ran them on Results:
Conclusions:
So I would be really keen to see this safety gap closed. If we are really worried about performance we could add |
kngwyu
reviewed
May 3, 2020
davidhewitt
added a commit
to davidhewitt/pyo3
that referenced
this pull request
May 3, 2020
As per feedback on PyO3#890
Member
Author
|
I've undone the change for |
davidhewitt
added a commit
to davidhewitt/pyo3
that referenced
this pull request
May 3, 2020
As per feedback on PyO3#890
1579307 to
e7703d5
Compare
As per feedback on PyO3#890
e7703d5 to
6f74fe6
Compare
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #883, I think these are a few cases where we should be converting borrowed objects to owned objects for safety reasons.
Closes #883.