Allow #[classattr] on associated constants#914
Merged
kngwyu merged 2 commits intoPyO3:masterfrom May 9, 2020
Merged
Conversation
Contributor
scalexm
commented
May 8, 2020
davidhewitt
reviewed
May 8, 2020
Member
davidhewitt
left a comment
There was a problem hiding this comment.
Very pleased to see this 👍
| pub fn impl_py_class_attribute(spec: &FnSpec<'_>, wrapper: &TokenStream) -> TokenStream { | ||
| let python_name = &spec.python_name; |
Member
There was a problem hiding this comment.
I understand why you did this refactoring but I think I preferred how it was before, to keep symmetry with the the other impl_py_method_xyz functions.
Contributor
Author
There was a problem hiding this comment.
I hesitated making this change indeed. I’ll write two functions, it’ll duplicate code slightly but will preserve the symmetry.
Member
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.