Merged
Conversation
4bcc44a to
cd85cd2
Compare
Member
|
Thank you! In addition, it would be great if we have a review from someone with expertise in Python(e.g., @birkenfeld). |
birkenfeld
reviewed
May 18, 2020
cd85cd2 to
b179855
Compare
Member
Author
In the interest of not duplicating things I'm going to switch to use Thanks for the review @birkenfeld - I've pushed some changes based on your feedback 👍 |
Member
|
@birkenfeld Thank you for your review 🙂 |
b179855 to
2813d2e
Compare
Member
Author
|
Thanks, have addressed the final points of feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #374
Tried to keep it clear and short, but cover all relevant detail. Happy to edit any terms, wording or other suggestions you have.