Cleanups to ensure GIL-safety of Py<T> and PyObject methods#970
Merged
kngwyu merged 1 commit intoPyO3:masterfrom Jun 15, 2020
Merged
Cleanups to ensure GIL-safety of Py<T> and PyObject methods#970kngwyu merged 1 commit intoPyO3:masterfrom
kngwyu merged 1 commit intoPyO3:masterfrom
Conversation
kngwyu
reviewed
Jun 13, 2020
kngwyu
reviewed
Jun 13, 2020
kngwyu
approved these changes
Jun 13, 2020
Member
kngwyu
left a comment
There was a problem hiding this comment.
Thank you for this hard work!
I have a minor concern about naming but other than that LGTM 👍
Member
Author
|
Updated to use |
Member
|
LGTM, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #949
This introduces
Pythonarguments toPy<T>andPyObjectmethods which really should be requiring the GIL.Doing this higlighted a couple of other places across the codebase which could be tweaked:
PyTypeObject::type_objectnow returns&PyTypeinstead ofPy<PyType>- should be faster as now no reference count increase needed.PyTuple::sliceandPyTuple::split_fromnow return&PyTuple.