Add support for arrays of ASCII and Unicode strings#378
Conversation
ecdfac5 to
f8c4ec1
Compare
|
Worked great! This was a very painless way to parse fixed-size ASCII and Unicode strings into numpy arrays. Thank you for doing all the work that I had aimed to do, it is really appreciated. One small nit: it took me a while to understand that the I couldn't think of any better names, but maybe one of:
I thought about In [5]: x = np.array(['a', 'b', 'c', 'd'], dtype='S1').reshape((2, 2))
In [6]: x
Out[6]:
array([[b'a', b'b'],
[b'c', b'd']], dtype='|S1')and I think the precise way to refer to this is a (2, 2) numpy array of dtype S1, so the way to construct that should be explicit in rust-numpy. Anyway, thanks for all the help! |
f8c4ec1 to
8784135
Compare
That is literally the first sentence of its docs. 😉 But I agree, the names are somewhat misleading as these not related to |
09385ca to
4dce32f
Compare
kngwyu
left a comment
There was a problem hiding this comment.
I'm really happy to see this finally comes with const generics. Cool. I left some minor comments.
4dce32f to
5305469
Compare
5305469 to
80d962b
Compare
|
@kngwyu I think this is ready to merge as I have just branched off the |
kngwyu
left a comment
There was a problem hiding this comment.
I have two minor comments on the document, but otherwise, it looks good. Thank you for achieving this!
80d962b to
e32ffe1
Compare
…rt Unicode arrays whose element length is know at compile time.
e32ffe1 to
ea5033f
Compare
This supports Unicode arrays whose element length is know at compile time.
Closes #141