chore(distutils): remove distutils usages#336
Merged
davidhewitt merged 1 commit intoPyO3:mainfrom Aug 11, 2023
Merged
Conversation
stegayet
force-pushed
the
chore/remove-distutils-usage
branch
2 times, most recently
from
c9c83a5 to
0400105
Compare
Contributor
Author
|
|
davidhewitt
reviewed
May 15, 2023
Member
davidhewitt
left a comment
davidhewitt
left a comment
There was a problem hiding this comment.
Thanks for working on this! Some initial suggestions which may help out...
setuptools_rust/setuptools_ext.py
Outdated
| from distutils import log | ||
| from distutils.command.clean import clean | ||
| import logging | ||
| from setuptools.command.clean import clean |
Member
There was a problem hiding this comment.
This is only used for type checking, so I think you could leave it as distutils and put it under an if TYPE_CHECKING guard?
Contributor
Author
There was a problem hiding this comment.
It seems to be used not only for typing as it breaks the CI, trying to use vendorized version of distutils in the meantime.
stegayet
force-pushed
the
chore/remove-distutils-usage
branch
from
0400105 to
7fd029d
Compare
Member
davidhewitt
force-pushed
the
chore/remove-distutils-usage
branch
from
7fd029d to
e46b7c3
Compare
Member
|
For now I've rebased and removed the import of |
Contributor
Author
|
Did not have time to keep this work going further, sorry for that 👍 |
kraj
pushed a commit
to YoeDistro/poky
that referenced
this pull request
Dec 15, 2023
As allowed by PyO3/setuptools-rust#336 (From OE-Core rev: b400ef172c3e10828391957570cdd57234f1590e) Signed-off-by: Alexander Kanavin <alex@linutronix.de> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
kraj
pushed a commit
to YoeDistro/poky
that referenced
this pull request
Dec 16, 2023
As allowed by PyO3/setuptools-rust#336 (From OE-Core rev: b400ef172c3e10828391957570cdd57234f1590e) Signed-off-by: Alexander Kanavin <alex@linutronix.de> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
kraj
pushed a commit
to YoeDistro/poky
that referenced
this pull request
Dec 16, 2023
As allowed by PyO3/setuptools-rust#336 (From OE-Core rev: b400ef172c3e10828391957570cdd57234f1590e) Signed-off-by: Alexander Kanavin <alex@linutronix.de> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
kraj
pushed a commit
to YoeDistro/poky
that referenced
this pull request
Dec 16, 2023
As allowed by PyO3/setuptools-rust#336 (From OE-Core rev: 550dce75d0a9ff1196f62970b726b67b4eadd9c5) Signed-off-by: Alexander Kanavin <alex@linutronix.de> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
kraj
pushed a commit
to YoeDistro/poky
that referenced
this pull request
Dec 18, 2023
As allowed by PyO3/setuptools-rust#336 (From OE-Core rev: 550dce75d0a9ff1196f62970b726b67b4eadd9c5) Signed-off-by: Alexander Kanavin <alex@linutronix.de> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
kraj
pushed a commit
to YoeDistro/poky
that referenced
this pull request
Dec 18, 2023
As allowed by PyO3/setuptools-rust#336 (From OE-Core rev: 768c884d34e60033ba36bb35122a1904aee9987d) Signed-off-by: Alexander Kanavin <alex@linutronix.de> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
kraj
pushed a commit
to YoeDistro/poky
that referenced
this pull request
Dec 19, 2023
As allowed by PyO3/setuptools-rust#336 (From OE-Core rev: f80986b33bff2b66719d7754d65412d925dc37e3) Signed-off-by: Alexander Kanavin <alex@linutronix.de> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
halstead
pushed a commit
to yoctoproject/poky
that referenced
this pull request
Dec 20, 2023
As allowed by PyO3/setuptools-rust#336 (From OE-Core rev: ca452dd6b1b6799cf70dac93f7fac0746d8c43bc) Signed-off-by: Alexander Kanavin <alex@linutronix.de> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
halstead
pushed a commit
to openembedded/openembedded-core
that referenced
this pull request
Dec 20, 2023
As allowed by PyO3/setuptools-rust#336 Signed-off-by: Alexander Kanavin <alex@linutronix.de> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
halstead
pushed a commit
to yoctoproject/poky
that referenced
this pull request
Dec 20, 2023
As allowed by PyO3/setuptools-rust#336 (From OE-Core rev: ca452dd6b1b6799cf70dac93f7fac0746d8c43bc) Signed-off-by: Alexander Kanavin <alex@linutronix.de> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
halstead
pushed a commit
to yoctoproject/poky
that referenced
this pull request
Dec 20, 2023
As allowed by PyO3/setuptools-rust#336 (From OE-Core rev: ca452dd6b1b6799cf70dac93f7fac0746d8c43bc) Signed-off-by: Alexander Kanavin <alex@linutronix.de> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
halstead
pushed a commit
to yoctoproject/poky
that referenced
this pull request
Dec 20, 2023
As allowed by PyO3/setuptools-rust#336 (From OE-Core rev: ca452dd6b1b6799cf70dac93f7fac0746d8c43bc) Signed-off-by: Alexander Kanavin <alex@linutronix.de> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
kraj
pushed a commit
to YoeDistro/poky
that referenced
this pull request
Dec 20, 2023
As allowed by PyO3/setuptools-rust#336 (From OE-Core rev: fd3069559579e72cc20fad13f758621832326e1c) Signed-off-by: Alexander Kanavin <alex@linutronix.de> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
kraj
pushed a commit
to YoeDistro/poky
that referenced
this pull request
Dec 20, 2023
As allowed by PyO3/setuptools-rust#336 (From OE-Core rev: fd3069559579e72cc20fad13f758621832326e1c) Signed-off-by: Alexander Kanavin <alex@linutronix.de> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
halstead
pushed a commit
to yoctoproject/poky
that referenced
this pull request
Dec 20, 2023
As allowed by PyO3/setuptools-rust#336 (From OE-Core rev: ca452dd6b1b6799cf70dac93f7fac0746d8c43bc) Signed-off-by: Alexander Kanavin <alex@linutronix.de> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
halstead
pushed a commit
to yoctoproject/poky
that referenced
this pull request
Dec 20, 2023
As allowed by PyO3/setuptools-rust#336 (From OE-Core rev: ca452dd6b1b6799cf70dac93f7fac0746d8c43bc) Signed-off-by: Alexander Kanavin <alex@linutronix.de> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
halstead
pushed a commit
to yoctoproject/poky
that referenced
this pull request
Dec 20, 2023
As allowed by PyO3/setuptools-rust#336 (From OE-Core rev: ca452dd6b1b6799cf70dac93f7fac0746d8c43bc) Signed-off-by: Alexander Kanavin <alex@linutronix.de> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
kraj
pushed a commit
to YoeDistro/poky
that referenced
this pull request
Dec 21, 2023
As allowed by PyO3/setuptools-rust#336 (From OE-Core rev: fd3069559579e72cc20fad13f758621832326e1c) Signed-off-by: Alexander Kanavin <alex@linutronix.de> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
halstead
pushed a commit
to yoctoproject/poky
that referenced
this pull request
Dec 21, 2023
As allowed by PyO3/setuptools-rust#336 (From OE-Core rev: ca452dd6b1b6799cf70dac93f7fac0746d8c43bc) Signed-off-by: Alexander Kanavin <alex@linutronix.de> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
halstead
pushed a commit
to yoctoproject/poky
that referenced
this pull request
Dec 21, 2023
As allowed by PyO3/setuptools-rust#336 (From OE-Core rev: ca452dd6b1b6799cf70dac93f7fac0746d8c43bc) Signed-off-by: Alexander Kanavin <alex@linutronix.de> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
hsteinhaus
pushed a commit
to emobotics-dev/poky
that referenced
this pull request
Feb 23, 2024
As allowed by PyO3/setuptools-rust#336 (From OE-Core rev: ca452dd6b1b6799cf70dac93f7fac0746d8c43bc) Signed-off-by: Alexander Kanavin <alex@linutronix.de> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
distutilsmodule usage is deprecated since Python 3.10 and will be removed in Python 3.12, this PR gets rid of remaining usages of this module.Replacements are taken from https://peps.python.org/pep-0632/#migration-advice and https://setuptools.pypa.io/en/latest/deprecated/distutils-legacy.html.
How this has been tested ?
To be checked