Include py.typed when packaging.#338
Merged
davidhewitt merged 2 commits intoPyO3:mainfrom Jun 1, 2023
clokep:py-typed
Merged
Conversation
davidhewitt
reviewed
May 31, 2023
Member
davidhewitt
left a comment
There was a problem hiding this comment.
Thanks! Could you please add a Packaging CHANGELOG entry?
Contributor
Author
Done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#186 added a
py.typedfile, but this isn't packaged automatically so other packages (which depend on setuptools-rust) are unable to take advantage of the type hints in it.I ran
python -m buildbefore and after this change: