raise minimum python version to 3.8 and drop typing_extensions#357
Merged
davidhewitt merged 1 commit intoPyO3:mainfrom Aug 24, 2023
nekopsykose:typing-ext-opt
Merged
raise minimum python version to 3.8 and drop typing_extensions#357davidhewitt merged 1 commit intoPyO3:mainfrom nekopsykose:typing-ext-opt
davidhewitt merged 1 commit intoPyO3:mainfrom
nekopsykose:typing-ext-opt
Conversation
Contributor
Author
|
ah, mypy requires the specific Literal for itself.. |
Contributor
Author
|
explicit seems to work instead |
Member
|
Given that setuptools now requires 3.8, I'd also be ok with doing the same here to simplify things. |
Contributor
Author
|
hm, that also works. sure |
Member
|
Thanks, looks like two final things needed here please:
|
Contributor
Author
|
good catch, thanks :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
typing.Literal was in python 3.8, so there isn't a need for this dependency on anything newer