fix: Skip previous encoding workaround for fixed xarray versions#401
Merged
lkstrp merged 2 commits intoPyPSA:masterfrom Nov 11, 2024
Merged
fix: Skip previous encoding workaround for fixed xarray versions#401lkstrp merged 2 commits intoPyPSA:masterfrom
lkstrp merged 2 commits intoPyPSA:masterfrom
Conversation
see reported issue pydata/xarray#7691 and pr pydata/xarray#8713 which was included into xarray v2024.03.0
Member
|
We could also just pin xarray now |
Member
Author
I guess with all the changes xarray is undergoing, having a half-year old version as lower bound is quite acceptable, true. |
Collaborator
|
Thanks for the cleanup. I'm also in favour of restricting the |
Member
Author
The dataarrays we receive from CDS has in xarray an encoding of |
Member
Author
|
Ok, i replaced the implementation by a new version pin. |
lkstrp
approved these changes
Nov 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to a workaround introduced by @euronion in #236 for an encoding issue in xarray (pydata/xarray#7691), which was fixed by (pydata/xarray#8713) and eventually included xarray v2024.03.0 (https://github.com/pydata/xarray/releases/tag/v2024.03.0).
Checklist
doc.environment.yaml,environment_docs.yamlandsetup.py(if applicable).doc/release_notes.rstof the upcoming release is included.