Conversation
lkstrp
left a comment
There was a problem hiding this comment.
Thank you @finozzifa !
I added the repo to the pre-commit ci
lkstrp
left a comment
There was a problem hiding this comment.
Beautiful! Full Ruff integration and you even added reuse compliance.
There is one thing left: You took over the licences from pypsa-eur, but this repo is already licensed under the GPL-3.0 licence. We don't want to change the licence, which would also be quite a heavy process.
So instead of adding MIT etc. in LICENSES/, can we just use GPL-3.0 in all SPDX identifiers?
|
To summarize: |
|
awesome, thanks! Regarding relicensing, xref this stale PR #87 . Maybe someone wants to pick it up again? |
Closes # (if applicable).
Changes proposed in this Pull Request
The contribution proposes:
-) the addition of .pre-commit-config.yaml
-) adding the license mentions in the necessary files
-) fixing typos as suggested by ruff
Testing
As a test, I have re-executed the snakemake rule compile_cost_assumptions. The newly generated files are identical to previous ones, apart from what detailed below.
The changes are caused by the following typo corrections:
costs_2020.csv
costs_2025.csv
costs_2030.csv
costs_2035.csv
costs_2040.csv
costs_2045.csv
costs_2050.csv
Checklist
doc.environment.yaml(if applicable).doc/release_notes.rstof the upcoming release is included.