Enhancements for TableHeadings & CellEdit, Placeholders, autocomplete combo, various fixes and new examples #313

ssweber · 2023-05-16T20:45:21Z

See below for up-to-date video.

I changed to datetime as dt so we can do isinstance(value, dt.date) before isinstance(value, date) or isinstance(value, datetime.date) doesn't work

This fills in sg.Text if it has a fk-relationship Don't compare it in records_changed Add an empty col in place of the required_marker

Go ahead and cast the table_value, since we maybe comparing dates, and table_value will be a str since Sqlite stores them as such.

This fills in description_column if col has fk-rels. Also simplified logic

…ated columns

This currently isn't integrated in any auto-logic, but user could do: # Add a placeholder to the search input ss.add_placeholder_to( win["Orders:search_input"], "🔍 Search...", ) I'll add a video for it.

ssweber · 2023-05-16T21:15:07Z

This fixes most of the things I saw when building the “orders.py” sqlite example.

I tried to break them out in comments, but if there’s something you’d like explained or changed, let me know!

I’d like your thoughts on the order example, in general, and if you’re OK on using it (in an annotated video) in the readme.

Logo
major features bullet points
then short video.

…e for 0 or 0.0

PySimpleSQL · 2023-05-29T01:07:10Z

Regarding the new search - does it wrap around like the original version? I'm hoping to get a chance to actually test it tonight, I just figured I would ask while I was thinking about it

…

On Tue, May 16, 2023 at 5:24 PM ssweber ***@***.***> wrote: Forgot I videoed that in #312 <#312> — Reply to this email directly, view it on GitHub <#313 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQX2REU3GH7EECJ4S3ILQ53XGPV7HANCNFSM6AAAAAAYEFTDIU> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

PySimpleSQL · 2023-05-29T01:23:04Z

I pulled your WIP branch. Unfortunately, nothing at all is working for me. I wonder if there are some cross-platform issues happening, since I'm running Linux.

/home/jondecker76/PycharmProjects/pysimplesql/venv/bin/python /home/jondecker76/PycharmProjects/pysimplesql/examples/SQLite_examples/journal_external.py ***** pysimplesql update from develop to 2.3.0 (released 2023-02-04 00:19:56) available! Be sure to run pip3 install pysimplesql --upgrade ***** INFO:pysimplesql.pysimplesql:Opening database: Journal.db INFO:pysimplesql.pysimplesql:Automatically generating dataset for each table in the sqlite database INFO:pysimplesql.pysimplesql:Automatically adding foreign key relationships INFO:pysimplesql.pysimplesql:Requerying all datasets INFO:pysimplesql.pysimplesql:Executing query: SELECT "Journal".* FROM "Journal" LEFT JOIN "Mood" ON "Journal"."mood_id"="Mood"."id" ORDER BY "title" ASC None INFO:pysimplesql.pysimplesql:Executing query: SELECT "Mood".* FROM "Mood" ORDER BY "name" ASC None INFO:pysimplesql.pysimplesql:Binding Window to Form INFO:pysimplesql.pysimplesql:Automapping elements Traceback (most recent call last): File "/home/jondecker76/PycharmProjects/pysimplesql/examples/SQLite_examples/journal_external.py", line 31, in <module> frm = ss.Form(driver, bind_window=win) # <=== Here is the magic! File "/home/jondecker76/PycharmProjects/pysimplesql/pysimplesql/pysimplesql.py", line 3007, in __init__ self.bind(self.window) File "/home/jondecker76/PycharmProjects/pysimplesql/pysimplesql/pysimplesql.py", line 3051, in bind self.auto_map_elements(win) File "/home/jondecker76/PycharmProjects/pysimplesql/pysimplesql/pysimplesql.py", line 3419, in auto_map_elements element.add_placeholder( File "/home/jondecker76/PycharmProjects/pysimplesql/pysimplesql/pysimplesql.py", line 5305, in add_placeholder self._add_binds() File "/home/jondecker76/PycharmProjects/pysimplesql/pysimplesql/pysimplesql.py", line 5425, in _add_binds self.binds[event] = widget.bind(event, disable_placeholder_select, "+") File "/usr/lib/python3.10/tkinter/__init__.py", line 1421, in bind return self._bind(('bind', self._w), sequence, func, add) File "/usr/lib/python3.10/tkinter/__init__.py", line 1375, in _bind self.tk.call(what + (sequence, cmd)) _tkinter.TclError: bad event type or keysym "/"

I'm going to keep combing through all of your updates so I can try to catch up.

ssweber · 2023-05-29T01:43:57Z

really good to hear from you! I was starting to worry and miss your feedback.

If you’d like, just comment out the “add_placeholder” call in auto_map_elements, there must be something different on Linux/ or your version of tkinter.

The “new search” still starts with the first search order column, then second, etc until it finds a match. I just reworked it to map the description column.

ssweber · 2023-05-29T01:46:07Z

Looks like it doesn’t like this bind <Control-/> - we could delete that, very unusually for someone to use that over ctrl-a

ssweber · 2023-05-29T01:46:54Z

GitHub doesn’t like me posting it. Let’s try this again <Control-/>

PySimpleSQL · 2023-05-29T01:50:40Z

Yeah, sorry about not checking in. Its been pretty rough. Things are starting to clear up at work, so that will help a lot I commented out lines 3590-3593 as well as lines24 and 5425 and can get the examples to run. I tried testing the search but didn't have any luck as of yet

…

On Sun, May 28, 2023 at 9:47 PM ssweber ***@***.***> wrote: GitHub doesn’t like me posting it. Let’s try this again <Control-/> — Reply to this email directly, view it on GitHub <#313 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQX2REQ2EQ773B6U7ZQIDZDXIP5ZRANCNFSM6AAAAAAYEFTDIU> . You are receiving this because you were mentioned.Message ID: ***@***.***>

ssweber · 2023-05-29T01:53:03Z

Weird! Ok, looks like I need to get a Linux / alternative Python versions to test with setup going.

ssweber · 2023-05-29T02:01:56Z

Sorry to hear things have been so rough.

Do you like the functionality as videoed? I will have some time tomorrow to debug

PySimpleSQL · 2023-05-29T02:09:02Z

Yes, your demo is awesome. I definitely like the way it looks and operates. Hopefully it won't take much to get things running well on Linux as well. I'm sure it's something simple

…

On Sun, May 28, 2023 at 10:02 PM ssweber ***@***.***> wrote: Sorry to hear things have been so rough. Do you like the functionality as videoed? I will have some time tomorrow to debug — Reply to this email directly, view it on GitHub <#313 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQX2REVPXKEDAEFHWTSFL23XIP7SBANCNFSM6AAAAAAYEFTDIU> . You are receiving this because you were mentioned.Message ID: ***@***.***>

ssweber · 2023-05-29T02:12:36Z

Awesome. Ok I’m off for the night. If you figure it out great, otherwise I’ll look into it tomorrow. 😄

PySimpleSQL · 2023-05-29T02:15:48Z

Regarding the error on line 5424, I replaced "<Control-/>" with "<Control-slash>" and that now works with Linux (and I would think it would work with Windows too). I'll mess around a little more tonight on the other issue. I'm pretty far behind, so I'm going to have to get familiar with the new additions

…

On Sun, May 28, 2023 at 10:12 PM ssweber ***@***.***> wrote: Awesome. Ok I’m off for the night. If you figure it out great, otherwise I’ll look into it tomorrow. 😄 — Reply to this email directly, view it on GitHub <#313 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQX2REQBLZRZXFJJINM7RELXIQAZ7ANCNFSM6AAAAAAYEFTDIU> . You are receiving this because you were mentioned.Message ID: ***@***.***>

PySimpleSQL · 2023-05-29T02:18:30Z

Putting this here for reference: Line 3590 is the other issue with an AttributeError: 'Input' object has no attribute 'add_placeholder' Traceback (most recent call last): File "/home/jondecker76/PycharmProjects/pysimplesql/examples/SQLite_examples/journal_external.py", line 31, in <module> frm = ss.Form(driver, bind_window=win) # <=== Here is the magic! File "/home/jondecker76/PycharmProjects/pysimplesql/pysimplesql/pysimplesql.py", line 3007, in __init__ self.bind(self.window) File "/home/jondecker76/PycharmProjects/pysimplesql/pysimplesql/pysimplesql.py", line 3052, in bind self.auto_map_events(win) File "/home/jondecker76/PycharmProjects/pysimplesql/pysimplesql/pysimplesql.py", line 3590, in auto_map_events self.window[search_box].add_placeholder( AttributeError: 'Input' object has no attribute 'add_placeholder' Process finished with exit code 1

…

On Sun, May 28, 2023 at 10:15 PM Jon Decker ***@***.***> wrote: Regarding the error on line 5424, I replaced "<Control-/>" with "<Control-slash>" and that now works with Linux (and I would think it would work with Windows too). I'll mess around a little more tonight on the other issue. I'm pretty far behind, so I'm going to have to get familiar with the new additions On Sun, May 28, 2023 at 10:12 PM ssweber ***@***.***> wrote: > Awesome. Ok I’m off for the night. If you figure it out great, otherwise > I’ll look into it tomorrow. 😄 > > — > Reply to this email directly, view it on GitHub > <#313 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AQX2REQBLZRZXFJJINM7RELXIQAZ7ANCNFSM6AAAAAAYEFTDIU> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> >

ssweber · 2023-05-29T12:22:30Z

Sorry to waste your time. That’s fixed now, and it seems tkinter on windows is happy with the Control-slash too!

I was only testing on the orders.py example, which uses an image for the search button, so I forgot to change the other layout else to use the subclassed Input instead of sg.Input. I really need to learn my lesson on testing with the other examples!

we probably should rename Combo -> AutocompleteCombo, and Input/Multiline to EnhancedInput/EnhancedMline for debugging purposes.

Thoughts on names for Input/Multiline? Right now they are only enhanced to support placeholders, but I’ll want to add type/length ability in the future. (eg only allow a two-digit int, a float, add dashes in-between dates as you type, etc)

ssweber · 2023-05-29T12:38:01Z

I tested the journal-internal, and it seems like search is working as intended, but let me know 😅

ssweber · 2023-05-29T17:12:57Z

I’m sorry, no, I didn’t understand how search worked before: “Successive calls will search from the current position, and wrap around back to the beginning.” I will either revert, and add back in the description-column mapping, or see how to accomplish using new method.

Need to read a bit more carefully

ssweber · 2023-05-29T17:15:24Z

Honestly, maybe what I’ll do is fix that, and then do a fresh pull request that again try’s to consolidate the different changes. I’ve rewritten things several times in this branch, so it’s not very clean anymore

ssweber · 2023-05-29T19:41:07Z

Let me know if you like #320 better than what we have now. I think we’d make a @Property DataSet.filtered_rows, that tables/combo/listbox/slider selectors would get their rows from.

for the filter example I

subclassed the Input, put a reference to self.dataset, on key-release update_selectors(self.key), and wrote string to dataset.search_string
table_values creates a mask for rows where search_order columns contain dataset.search_string.

…beginning

ssweber · 2023-05-30T02:02:49Z

Tomorrow I’ll try to get up an easier-to-review PR, without all the in-between rewrites, and no code-reorganizing.

…as well as make sure I got search right this time.

ssweber added 17 commits May 16, 2023 16:19

Update imports

72ca79a

I changed to datetime as dt so we can do isinstance(value, dt.date) before isinstance(value, date) or isinstance(value, datetime.date) doesn't work

Fix how we handle sg.Text

b1b1cf9

This fills in sg.Text if it has a fk-relationship Don't compare it in records_changed Add an empty col in place of the required_marker

Subtle changes to value_changed

41938b0

Go ahead and cast the table_value, since we maybe comparing dates, and table_value will be a str since Sqlite stores them as such.

Rewritten search

7a5dd1b

This fills in description_column if col has fk-rels. Also simplified logic

Add try-except to set_by_pk

c31f4f0

Update set_current to write an event to the main loop

c0115f9

Removing some outdated comments

423febd

Fix nan and numpy types showing in sg.Table / Add supported for gener…

2caf2b7

…ated columns

Safeguards for closing popups.

8dd585e

Updates to casting / adding dt. datetime

5f2b676

Add save_enabled to sg.Table headings (first column)

7dc33b6

Date Datepicker, and displaying boolean as Checkboxes

61a74a7

Update checkbox_to_bool

19a35b6

Add add_placeholder_to

97d2fea

This currently isn't integrated in any auto-logic, but user could do: # Add a placeholder to the search input ss.add_placeholder_to( win["Orders:search_input"], "🔍 Search...", ) I'll add a video for it.

Move LangFormat to be more logically placed (under LanguagePack

7a3d17b

New examples, orders & checkbox_behavior

ca8f88a

Black fix

2e1e814

ssweber changed the title ~~WIP, broken out in commits~~ Enhancements for TableHeadings & CellEdit, also various fixes and new examples May 16, 2023

ssweber added 11 commits May 16, 2023 20:39

Keep original info popup open, if user double-clicks save (for instance)

e72fced

All sg.Windows use icon=themepack.icon

8f442a0

Don't prompt_save after search

64f2566

Add popup to failed search

7719906

Clean up orders.py example a bit

af34216

Cleanup orders.py

466d39f

convert: `is type(element) to isinstance()

1653309

Missed one isinstance replacement

037529e

These arnt isinstance yet, they are just objects

2cd2be2

Fix pd.Series converting int to floats, Fix get_current returning Non…

956049b

…e for 0 or 0.0

Add basic *Required to sg.Inputs, and 🔍 Search...

c56233b

ssweber added 6 commits May 26, 2023 10:45

small fix

da3e258

More LazyTable cleanup

16d7220

Cleaning up sg.table to support pypi version and github

0b7b74d

Small comment

ea9ea89

Start Work on Readme

7b93bd1

Update README2.md

2170303

PySimpleSQL and others added 2 commits May 28, 2023 22:38

replaced <Control-/> with <Control-slash> for linux compatibility

cd86f62

Fix for add_placeholder missing

dc070e1

fix search to start at current position, +1, and wrap back around to …

4541de7

…beginning

Renaming subclassed widgets

b47b125

ssweber closed this May 30, 2023

ssweber deleted the wip-logically branch May 30, 2023 13:40

Enhancements for TableHeadings & CellEdit, Placeholders, autocomplete combo, various fixes and new examples #313

Enhancements for TableHeadings & CellEdit, Placeholders, autocomplete combo, various fixes and new examples #313

Uh oh!

Conversation

ssweber commented May 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ssweber commented May 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PySimpleSQL commented May 29, 2023 via email

Uh oh!

PySimpleSQL commented May 29, 2023

Uh oh!

ssweber commented May 29, 2023

Uh oh!

ssweber commented May 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ssweber commented May 29, 2023

Uh oh!

PySimpleSQL commented May 29, 2023 via email

Uh oh!

ssweber commented May 29, 2023

Uh oh!

ssweber commented May 29, 2023

Uh oh!

PySimpleSQL commented May 29, 2023 via email

Uh oh!

ssweber commented May 29, 2023

Uh oh!

PySimpleSQL commented May 29, 2023 via email

Uh oh!

PySimpleSQL commented May 29, 2023 via email

Uh oh!

ssweber commented May 29, 2023

Uh oh!

ssweber commented May 29, 2023

Uh oh!

ssweber commented May 29, 2023

Uh oh!

ssweber commented May 29, 2023

Uh oh!

ssweber commented May 29, 2023

Uh oh!

ssweber commented May 30, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ssweber commented May 16, 2023 •

edited

Loading

ssweber commented May 16, 2023 •

edited

Loading

ssweber commented May 29, 2023 •

edited

Loading