[Sportec] Missing Events and Qualifiers

[UnravelSports]

Hi,

I was going over the parsed, implemented, not supported and unknown EventTypes for Sportec for the upcoming documentation release and below is a list of all the events that are currently not implemented:

• OtherBallAction > DefensiveClearance (either "true" or "false")
• BallClaiming > InterceptedBall (I don't know if this is a Goalkeeper event or a regular event)
• TacklingGame > DribbleEvaluation (either "successful" or "unsuccessful")
• Caution > CardColor (either "yellow" or "red", and maybe "secondYellow" but that I'm not sure of)

Then we also have some Kloppy types that I don't know exist in Sportec. We might need Sportec documentation to figure this out:

• EventType.PLAYER_ON EventType.PLAYER_OFF
• EventType.RECOVERY
• EventType.MISCONTROL

Then, for PassQualifiers I found (there may be more in the docs):

• <Pass Direction="throughBall"/>
• <Pass Direction="squarePass"/>
• <Pass Direction="diagonalBall"/> (is this PassQualifier.SWITCH_OF_PLAY?)
• <Pass Direction="backPass"/> (this doesn't exist yet as a PassQualifier in Kloppy)

Finally, the ShotAtGoal and SavedShot items have some interesting features we are currently not processing:

• <ShotAtGoal ChanceEvaluation="chance" xG="0.0299" CounterAttack="false" Pressure="0.79">
• <SavedShot SaveType="arms" SaveResult="held"/>
  • SaveResult="notCleared", SaveResult="held", SaveResult="cleared" (there can be more in the docs?)

[mrkthmpsn]

I think CardColor is already being processed: https://github.com/mrkthmpsn/kloppy/blob/887b5ef1e1fb219ab83cf389b890d258ba4c8132/kloppy/infra/serializers/event/sportec/deserializer.py#L417 ?

Would it be good to change the file used in the event data test to one of the newer, open matches? They're much more extensive than the current file. Or would these additions be unlikely to be something to be tested? I can see in the current Sportec tests that it's mainly testing general deserialization and some specific pass-receiver logic

[UnravelSports]

I might've missed that cards are already processed!

As for the tests, yes it would make sense. You'd have to rewrite some of the old tests though (to fit the new file), but it might be easiest to simply copy one or two events of each of the new events you're adding to the existing test file, or even easier to add a second file. That might be the least amount of work, but either way is good.