Fix type issues and short messages breaking inference#37
Open
tristanmckechnie wants to merge 1 commit intoPyThaiNLP:masterfrom
Open
Fix type issues and short messages breaking inference#37tristanmckechnie wants to merge 1 commit intoPyThaiNLP:masterfrom
tristanmckechnie wants to merge 1 commit intoPyThaiNLP:masterfrom
Conversation
Collaborator
|
Hi, Thank you for reporting the issues! I was not aware of them before. Having said that, would you mind sharing some data or scenario in which I can see the issues arise and the PR fix them? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I could not run the attacut-cli tool with gpu inference without specifying a type in line 178 of attact/dataloaders.py
Additionally, for my application of tokenizing short messages (tweets), some short messages created zero length tokens and so a words could not be retrieved. I added a simple if-else check to ensure a short message does not break the tokenization of many messags / lines.