summarize: Small variable rename and handle engine not found case#131
Merged
wannaphong merged 4 commits intoPyThaiNLP:devfrom Oct 20, 2018
bact:dev
Merged
summarize: Small variable rename and handle engine not found case#131wannaphong merged 4 commits intoPyThaiNLP:devfrom bact:dev
wannaphong merged 4 commits intoPyThaiNLP:devfrom
bact:dev
Conversation
Member
bact
commented
Oct 20, 2018
bact
commented
- add __ prefix for private class members
- summarize_text() will always return something (if summarization engine not found, return first n sentences)
- summarize_text() documentation
Merge back from PyThaiNLP main repo
- add __ prefix for private class members - summarize_text() will always return something (if summarization engine not found, return first n sentences)
wannaphong
approved these changes
Oct 20, 2018
Member
|
รวมเรียบร้อยแล้ว ขอบคุณครับ |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.