Skip to content

Clean code (/corpus, /tools, /ulmfit)#132

Merged
wannaphong merged 3 commits intoPyThaiNLP:devfrom
bact:dev
Oct 20, 2018
Merged

Clean code (/corpus, /tools, /ulmfit)#132
wannaphong merged 3 commits intoPyThaiNLP:devfrom
bact:dev

Conversation

@bact
Copy link
Member

@bact bact commented Oct 20, 2018

  • put corpus database url into CORPUS_DB_URL constant
  • sort imports, remove unused imports
  • add __ prefix for private class members
  • precompile patterns at initialization (ThaiTokenizer class)
  • use "not" for condition comparison (in a reasonable situation) with booleans (as suggested by PEP8)
  • make indent more consistent

bact added 2 commits October 20, 2018 22:30
@bact
Clean code
7a1b935 
- sort imports, remove unused imports
- add __ prefix for private member
- precompile patterns at initialization (ThaiTokenizer class)
- use "not" for condition comparison (in a reasonable situation) with booleans (as suggested by PEP8)
- make indent more consistent
@bact
put corpus database url into CORPUS_DB_URL constant
a7363d3
@coveralls
Copy link

coveralls commented Oct 20, 2018

Coverage Status

Coverage decreased (-0.1%) to 53.081% when pulling a7363d3 on bact:dev into 64519a5 on PyThaiNLP:dev.

@coveralls
Copy link

coveralls commented Oct 20, 2018 •
edited
Loading

Coverage Status

Coverage increased (+3.6%) to 56.829% when pulling 7d71561 on bact:dev into 64519a5 on PyThaiNLP:dev.

@wannaphong wannaphong merged commit 8f171ca into PyThaiNLP:dev Oct 20, 2018
@wannaphong wannaphong mentioned this pull request Nov 3, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wannaphong wannaphong wannaphong approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bact @coveralls @wannaphong

Comments