Code cleaning + small optimization#133
Merged
wannaphong merged 3 commits intoPyThaiNLP:devfrom Oct 21, 2018
bact:dev
Merged
Conversation
Member
bact
commented
Oct 21, 2018
bact
commented
- precompile regexes
- more description for each file (at the beginning)
- naming convention: rename thai2rom -> ThaiTransliterator [CamelCase for Class], romanization() -> romanize() [function name should be a verb]
- update examples and tests to new names
- add __ prefix for private members (ThaiTransliterator)
- make sure a function will always return something -- if no engine found, use default (romanize(), sentiment(), spell(), pos_tag())
- sort imports, remove unused imports
- make consistent indentation (replace tabs with spaces, make it 4-space indent)
- remove Python 2 condition checks
- precompile regexes - more description for each file (at the beginning) - naming convention: rename thai2rom -> ThaiTransliterator [CamelCase for Class], romanization() -> romanize() [function name should be a verb] - update examples and tests to new names - add __ prefix for private members (ThaiTransliterator) - make sure a function will always return something -- if no engine found, use default (romanize(), sentiment(), spell()) - sort imports, remove unused imports - make consistent indentation (replace tabs with spaces)
- make indentation - make sure pos tagger will always return something (will use "unigrame" and "pud" as default)
wannaphong
approved these changes
Oct 21, 2018
Closed
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.