Merge different soundex systems to one pythainlp.soundex module#138
Merged
wannaphong merged 6 commits intoPyThaiNLP:devfrom Oct 29, 2018
bact:dev
Merged
Merge different soundex systems to one pythainlp.soundex module#138wannaphong merged 6 commits intoPyThaiNLP:devfrom bact:dev
wannaphong merged 6 commits intoPyThaiNLP:devfrom
bact:dev
Conversation
Member
bact
commented
Oct 29, 2018
bact
commented
- Rename LK82 -> lk82, Udom83 -> udom83 (small case for function())
- Moved all lk82, udom83, and metasound to pythainlp.soundex
- Precompile regular expressions for lk82 and udom83
- Adjust the tests
Merge pull request #137 from bact/dev
wannaphong
approved these changes
Oct 29, 2018
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.