Remove obsoleted, unused, and experimental codes#140
Merged
bact merged 4 commits intoPyThaiNLP:devfrom Oct 31, 2018
bact:dev
Merged
Remove obsoleted, unused, and experimental codes#140bact merged 4 commits intoPyThaiNLP:devfrom bact:dev
bact merged 4 commits intoPyThaiNLP:devfrom
bact:dev
Conversation
Member
bact
commented
Oct 30, 2018
bact
commented
- Remove pyicu uses in collation (already have _thkey() for sort key)
- Remove hunspell uses in spell (already have Peter Norvig's checker)
- Remove pythainlp.text.Text (nltk Text wrapper) (user can do this by themselve)
- Remove pylexto uses in tokenization
- rename collation() to collate() (use verb and function name)
- Remove pyicu uses in collation (already have _thkey() for sort key) - Remove hunspell uses in spell (already have Peter Norvig's checker) - Remove pythainlp.text.Text (nltk Text wrapper) (user can do this by themselve) - Remove pylexto uses in tokenization
Merge from pythainlp/pythainlp
bact
changed the title
1 similar comment
wannaphong
approved these changes
Oct 30, 2018
Member
wannaphong
left a comment
wannaphong
left a comment
There was a problem hiding this comment.
ผมเช็คโค้ดแล้ว น่าจะไม่มีปัญหาอะไรนะครับ
Member
Author
|
ขอบคุณครับ งั้นผม merge เลยนะครับ :) |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.