Manage extra requires + merge g2p and romanization to one transliterate module#153
Merged
bact merged 14 commits intoPyThaiNLP:devfrom Nov 9, 2018
bact:dev
Merged
Manage extra requires + merge g2p and romanization to one transliterate module#153bact merged 14 commits intoPyThaiNLP:devfrom bact:dev
bact merged 14 commits intoPyThaiNLP:devfrom
bact:dev
Conversation
…terate module - add more test cases
Merge readme
* 'dev' of https://github.com/bact/pythainlp: Update README.md Update README.md Add link to master's README
Member
Author
|
Build fails, basically from missing imports (epitrain). Another issue related to imports. Have to decided how to deal with "optional packages" that used by some functionalities. |
- add extras_require to setup.py
Member
Author
|
Travis fails because: AppVeyor fails because there's no torch PyPI package for Windows. |
Member
Author
|
Test on Windows (AppVeyor) fails due to UnicodeDecodeError in artagger (#155) |
bact
changed the title
wannaphong
reviewed
Nov 9, 2018
- fastai==0.7.0
wannaphong
approved these changes
Nov 9, 2018
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.