More test cases - reached 80% coverage#156
Merged
bact merged 20 commits intoPyThaiNLP:devfrom Nov 10, 2018
bact:dev
Merged
Conversation
Merge from origin
Member
Author
|
AppVeyor failed because of network connection error- the TNC server did not respond in time. |
- more test cases for tokenize
Closed
- remove deepcut tests for now
Member
Author
|
80% แล้ว! Note: Slower and slower build timeAs the test coverage is improving, the build time for test is dramatically slower - as test cases are now hitting with functions that use some data models - and these models (like thai2vec, thainer, etc.) have to be downloaded fresh everytime for each single build. For discussion on how to solve this, please join #144. The proposal is, if the user chose the relevant extras_require option and if the licenses are permitted, all required data models should be installed once at the pip install time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.