add function for pos tag with transformers#857
Merged
wannaphong merged 5 commits intoPyThaiNLP:devfrom Nov 5, 2023
Merged
Conversation
|
Hello @MpolaarbearM! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2023-11-05 07:37:06 UTC |
Member
|
@MpolaarbearM Can you fix pep8 and delete ptagger_temp4XcDf.json file? |
Contributor
Author
|
@wannaphong yes I'll try and fix that |
…lp into postag_transformers
|
Kudos, SonarCloud Quality Gate passed!
|
This was referenced Nov 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








What does this changes
Add function to pos tagging using transformers in pos_tag.py. The function have 3 model which can be switch base on the name on the engine. Have test all engine on test_tag.py and there is no error. Also test assertRaise error value when the engine name does not match any of the engines name.
Your checklist for this pull request
🚨Please review the guidelines for contributing to this repository.