edited engine name and add phayathai pos_tag model to transformer_tag#871
edited engine name and add phayathai pos_tag model to transformer_tag#871MpolaarbearM wants to merge 2 commits intoPyThaiNLP:devfrom
Conversation
|
Hello @MpolaarbearM! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2023-11-30 11:25:44 UTC |
|
Kudos, SonarCloud Quality Gate passed!
|
|
Tag @pavaris-pm as they just made related changes in #865 and may have few comments. |
|
@MpolaarbearM I'm not sure about this. Did you sync the change from the upstream repo to your forked version repo before made this PR? since I've a discussion about model name / code refactoring with @bact and made change by adding dictionary lookup in PR #865, but seems like the change you've made in this PR did not match with the previous version that I do code refactorization krub. |
@MpolaarbearM i already fix it already by sync the change in new PR #873 . You can now close this PR after saw this comment krub. However, big thanks for your effort for training the pos tagging model on blackboard corpus. I promise that i will not forget to make a |
|
@pavaris-pm thank you very much krub! |








What does this changes
Add model lunarlist/pos_thai_phayathai to the pos tag transformer and fix some engine names being too long
What was wrong
How this fixes it
Fixes #...
Your checklist for this pull request
🚨Please review the guidelines for contributing to this repository.