Merged
Conversation
Collaborator
|
Will review this once we get free time from work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
save_pathandhide_elements.get_element:get location of element before scrolling, to avoid stale element exception..get_element: delete the temporary full screenshot.get_element: don't add ".png" to image_name, as the default value indicates that the name should include the extension.full_screenshot: use lower case function namefull_screenshot: revert Fix: Fixed issue when taking screenshots and images are displayed cro… #18, which causes the problems in issue Full Screenshot function not taking images for a page bigger than the window #21. I have not come across the problem mentioned in Fix: Fixed issue when taking screenshots and images are displayed cro… #18.full_screenshot: callhide_elementsbefore getting the final page sizefull_screenshot: callhide_elementson each rectangle. Currently the element is not hidden in the first iteration.get_element: Scroll to top of page before getting location, to get absolute coordinates. This might not fix location for all cases.hide_elements: use!importantkeyword to override any other display styles.