Bonus features: Copy/paste text Node; simple graphical visualization Node with options#80
Merged
Bonus features: Copy/paste text Node; simple graphical visualization Node with options#80
Conversation
Collaborator
|
Absolutely tremendous, worked out of the box for me on the football data. I actually have a |
Member
Author
|
Go for it! |
reddigari
approved these changes
May 2, 2020
diegostruk
approved these changes
May 2, 2020
Collaborator
diegostruk
left a comment
There was a problem hiding this comment.
This is great. Great job Matt!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds two new Node to support some of the nice-to-have features brought up in our last customer meeting. Not much has changed on the back-end besides the inclusion of two new Node classes. The front-end adds support for a 'textarea'
<SimpleInput>component and adds to the existing<GraphView>to render a<VegaLite>component.Table Creator Node

This switches the `file` input from the Read CSV node, into a text area `TextParameter`. This is the same as a `StringParameter` but with a different type to tell the front-end to render a larger space. Same CSV options for `sep` and `header` exist.Graph Node

This uses the Altair package to generate a JSON spec on the back-end from an incoming pandas DataFrame. The front-end uses a `loadGraph` function that calls the same `retrieveData` endpoint, but without processing for tabular display. The `` component then handles all the rendering from the JSON file.This uses the same simple parameters that exist like String and IntegerParameter. The
graph_typeoption could be modified to use a newSelectParameterwith a list of supported options (right now area, bar, line, and point graphs are supported). This might conflict with @reddigari's #78 work on form elements, so I kept the customization to a minimum here. It may also make sense to fork the old functionality into a component and keep the new visual/chart display in the<GraphView>component, but provided as-is for now.