Skip to content

Correct 'Github' to 'GitHub'#29

Merged
claytercek merged 2 commits intoPyaeSoneAungRgn:mainfrom
Cretezy:rename
Jan 20, 2026
Merged

Correct 'Github' to 'GitHub'#29
claytercek merged 2 commits intoPyaeSoneAungRgn:mainfrom
Cretezy:rename

Conversation

@Cretezy
Copy link
Contributor

@Cretezy Cretezy commented Sep 3, 2025

No description provided.

@Cretezy Cretezy changed the title Correct 'Github' to 'GitHub' in theme JSON Correct 'Github' to 'GitHub' Sep 3, 2025
@dontwanttothink
Copy link

This bothers me; getting it fixed would be awesome!

@claytercek
Copy link
Collaborator

Totally fair, only downside here is that this will reset the active theme for anyone who currently has one of the GitHub themes selected. I think we just have to decide if it's worth doing that to the ~130k folks who have installed it.

@dontwanttothink
Copy link

It’s obviously not necessarily a huge deal… but I will ask a question. Should this (tiny) typo be kept in perpetuity for the sake of avoiding that inconvenience? The download counter only goes up over time, so you could argue that it’s better done now than later. I’d also ask, maybe, how many of the 130 000 downloads correspond to an active user, and further, an active user with the theme set as default! Just some thoughts haha.

@claytercek
Copy link
Collaborator

Fair point! Lets merge it.

@claytercek claytercek merged commit 3d5c8d2 into PyaeSoneAungRgn:main Jan 20, 2026
handlename added a commit to handlename/dotfiles that referenced this pull request Feb 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants