-
Notifications
You must be signed in to change notification settings - Fork 565
Enable publication of coverage results from Jenkins #842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Collecting all conda-forge packages into a single "conda install" call - Moving the coverage setup so that teh downloaders will be covered
This brings the Jenkins driver in line with the Travis and Appveyor drivers: - coverage is configured through the .coveragerc file - we set up coverage to capture code run by subprocesses
Codecov Report
@@ Coverage Diff @@
## master #842 +/- ##
==========================================
- Coverage 66.92% 66.37% -0.56%
==========================================
Files 422 461 +39
Lines 67457 71638 +4181
==========================================
+ Hits 45148 47547 +2399
- Misses 22309 24091 +1782
Continue to review full report at Codecov.
|
|
This is ready to review. The apparent drop in coverage is because codecov found several new files (totaling 4400 lines) that previously had been completely skipped. hat increased outweighed the additional 2500 lines of code that were exercised. |
blnicho
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks pretty good but you left in quite a few commented lines of code which I think should either be removed or explained for future reference.
| os.sep.join([os.environ['WORKSPACE'], 'src', 'pyutilib.*']), | ||
| 'pyutilib.*', | ||
| ]) | ||
| #coverage_omit=','.join([ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason you left these commented lines in?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mostly left them in as breadcrumbs for "future me" / @whart222, when we are going through and trying to remember how things "used to work", especially if we find that this change breaks other Jenkins builds (apart from the ones supporting PR/master testing). I added a comment to this effect.
blnicho
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks fine.
Fixes #46.
Summary/Motivation:
This updates the Jenkins builds to use the same coverage approach/configuration as is used by Travis and Appveyor. Separately, the Jenkins builds have been updated to push coverage results to Codecov.
Note that implementing this requires a patched version of codecov, see codecov/codecov-python#187.
Changes proposed in this PR:
conda install"Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: