Bugfix with undefined children_hooks when package is None#565
Merged
edschofield merged 1 commit intoPythonCharmers:masterfrom Feb 21, 2024
Merged
Bugfix with undefined children_hooks when package is None#565edschofield merged 1 commit intoPythonCharmers:masterfrom
edschofield merged 1 commit intoPythonCharmers:masterfrom
Conversation
touch_import_top() is always called with a package within the futurize codebase, but it does have a code path where package can be None (e.g. import six instead of from six import string_types). Fixed a minor bug in this code path, so that a custom fixer can use it. Change-Id: Iec2891586fe852e35a91c69d2fb146645d7c53dd
Contributor
|
Thanks @azjps ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the code path in
touch_import_top()wherepackageisNone(e.g.import sixinstead offrom six import string_types). Fixed a minor bug in this code path, so that a custom fixer can use it.(
touch_import_top()is always called with a package within the futurize codebase.)