Conversation
|
I've not yet worked with |
|
Hi @ZlaTanskY, awesome! Could we go for |
|
I have replaced I also added the make command EDIT: I did not add black into the current |
|
Looks all good to me! Can you make it merge into the develop branch instead of the master? Then I'll approve it right away. The repo is structured as follows: master (released versions) > develop > issue branches. There's some info here: https://github.com/PythonPredictions/cobra/wiki/Contributing-guidelines-&-workflows. |
PROPOSAL
To have all developers align on codestyle, Python dev's created PEP8 style guide.
Some tools to help enforce this guide are included in this PR:
mypy)pydocstyle)pylint)pycodestyle)By using the
Makefile, it is easy to perform these checks by running the following command:make code-qaSimilarly the unit tests can be run by running the following command:
make test-unitOther commands can be found and/or added in the
Makefile.