Skip to content

Issue #65 categorical data preprocessor#82

Merged
sborms merged 3 commits intodevelopfrom
issue-#65-categorical_data_preprocessor
Aug 6, 2021
Merged

Issue #65 categorical data preprocessor#82
sborms merged 3 commits intodevelopfrom
issue-#65-categorical_data_preprocessor

Conversation

@sborms
Copy link
Copy Markdown
Contributor

@sborms sborms commented Aug 6, 2021

Expand categorical data preprocessor to regression case

Preprocessing - categorical_data_preprocessor

Changes made

  • added model_type parameter (classification, or regression)
  • avoided incidence weighting where needed (i.e. in case of regression as model_type)
  • added Kruskal-Wallis test for p-val calculation when regression
  • some doc fixes
  • added simple unit test regarding p-val calculation

Linked issues

Resolves #65

@sborms sborms added this to the v1.1.0 milestone Aug 6, 2021
@sborms sborms requested a review from sandervh14 August 6, 2021 08:09
Comment thread cobra/preprocessing/categorical_data_processor.py Outdated
@sborms sborms removed this from the v1.1.0 milestone Aug 6, 2021
Copy link
Copy Markdown
Contributor

@sandervh14 sandervh14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, OK!

@sborms sborms merged commit ecb7d90 into develop Aug 6, 2021
@sborms sborms deleted the issue-#65-categorical_data_preprocessor branch August 6, 2021 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants