Skip to content

Fixing model scoring problem #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sborms merged 1 commit into from
Sep 3, 2021
Merged

Fixing model scoring problem #94

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions cobra/model_building/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,7 +355,7 @@ def score_model(self, X: pd.DataFrame) -> np.ndarray:
"""
# We select predictor columns (self.predictors) here to
# ensure we have the proper predictors and the proper order!!!
return self.linear.predict(X[self.predictors])[:, 1]
return self.linear.predict(X[self.predictors])

def evaluate(self, X: pd.DataFrame, y: pd.Series,
split: str=None) -> float:
Expand Down Expand Up @@ -440,4 +440,3 @@ def _is_valid_dict(self, model_dict: dict) -> bool:
return False

return True