Fix ArgumentException crash when InfoPanel encounters paths with illegal characters #1736
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a crash in QuickLook's InfoPanel when it encounters file paths containing illegal characters. The error manifested as:
Root Cause:
The
InfoPanel.DisplayInfo()method was calling file system operations (File.GetLastWriteTime(),Path.GetFileName(), etc.) without defensive error handling. When QuickLook receives paths containing Windows-illegal characters like<>"|?*:or other invalid path constructs, these operations throw unhandledArgumentException, causing the application to crash.Solution:
Added comprehensive exception handling around all file system operations in
InfoPanel.DisplayInfo():ArgumentExceptionandPathTooLongExceptionArgumentException,UnauthorizedAccessException, andPathTooLongExceptionThe fix provides graceful fallback behavior:
Impact:
This ensures QuickLook remains stable and usable even when dealing with edge cases involving unusual file paths.
Fixes #1734.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.