Skip to content

Catch FileNotFoundException on contact import #815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
audax wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Catch FileNotFoundException on contact import #815

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
66e6c95
Catch FileNotFoundException on contact import
audax Jan 6, 2017
b61bd44
Merge branch 'master' into contact-import-errors
audax Jan 9, 2017
b31fbd9
Merge branch 'master' into contact-import-errors
audax Feb 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion qabelbox/src/main/java/de/qabel/qabelbox/contacts/view/views/ContactsFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ import org.jetbrains.anko.runOnUiThread
import rx.Observable
import rx.subjects.BehaviorSubject
import java.io.File
import java.io.FileNotFoundException
import java.util.concurrent.TimeUnit
import javax.inject.Inject

Expand Down Expand Up @@ -234,7 +235,12 @@ class ContactsFragment() : ContactsView, BaseFragment(true, true, true), AnkoLog
when (action) {
is ExternalFileAction -> {
val uri = resultData?.data
val file = activity.contentResolver.openFileDescriptor(uri, action.accessMode)
val file = try {
activity.contentResolver.openFileDescriptor(uri, action.accessMode)
} catch (e: FileNotFoundException) {
showImportFailedMessage()
Copy link
Contributor

@JoGir JoGir Jan 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import or export so may just show a default error

return
}
presenter.handleExternalFileAction(action, file.fileDescriptor)
}
else -> {
Expand Down