Skip to content

Separate out primitives#4640

Merged
beckykd merged 286 commits into
mainfrom
bd-new-toc
Apr 27, 2026
Merged

Separate out primitives#4640
beckykd merged 286 commits into
mainfrom
bd-new-toc

Conversation

@beckykd
Copy link
Copy Markdown
Collaborator

@beckykd beckykd commented Feb 6, 2026

Addresses part of #4613

Executor changes have been moved to #5028

Changes are extensive. Files to review follow:

Files with totally new content:

The rest of the changes are:

  • Old content split into new files (instead of having 1 topic for all primitives, there are now individual files for Estimator, and Sampler,
  • Updated / new links (due to the above)
  • Updated link formatting - Links should be /docs/guides, and a lot were just ./
  • Fixes to capitalization of primitive names, and use of "the" in front of primitive names

You can probably just ignore the files with changes of the third type, but you're welcome to review and commend on all 127 changed files if you so desire :)

@review-notebook-app
Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@beckykd beckykd mentioned this pull request Apr 23, 2026
Copy link
Copy Markdown
Collaborator

@jyu00 jyu00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we are almost there! Two extra comments:

  1. This PR no longer contains the Executor pages, but Executor section still shows up on the left nav.
  2. Can we move the Directed execution model (beta) page to be right after Introduction to primitives? It's also an intro/overview page that seems weird to be at the bottom.

Comment thread docs/guides/get-started-with-backend-primitives.mdx Outdated
Comment thread docs/guides/get-started-with-backend-primitives.mdx Outdated
Comment thread docs/guides/hello-world.ipynb
Comment thread docs/guides/hello-world.ipynb Outdated
Comment thread docs/guides/primitives.ipynb Outdated
Comment thread docs/guides/get-started-with-backend-primitives.mdx Outdated
Comment thread docs/guides/_toc.json Outdated
Comment thread docs/guides/hello-world.ipynb Outdated
jyu00
jyu00 previously approved these changes Apr 27, 2026
Copy link
Copy Markdown
Collaborator

@jyu00 jyu00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still seeing those stupid warnings from QiskitRuntimeService(), but I assume they'll go away once you re-run CI.

@beckykd
Copy link
Copy Markdown
Collaborator Author

beckykd commented Apr 27, 2026

I'm still seeing those stupid warnings from QiskitRuntimeService(), but I assume they'll go away once you re-run CI.
I changed the code, so they should. I'll keep an eye out!

@beckykd
Copy link
Copy Markdown
Collaborator Author

beckykd commented Apr 27, 2026

I'm still seeing those stupid warnings from QiskitRuntimeService(), but I assume they'll go away once you re-run CI.

I reran it and don't see the warnings now.

abbycross
abbycross previously approved these changes Apr 27, 2026
Copy link
Copy Markdown
Collaborator

@abbycross abbycross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥

Copy link
Copy Markdown
Collaborator

@abbycross abbycross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥 💥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

8 participants