Separate out primitives#4640
Merged
Merged
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Merged
jyu00
reviewed
Apr 23, 2026
Collaborator
jyu00
left a comment
There was a problem hiding this comment.
I think we are almost there! Two extra comments:
- This PR no longer contains the Executor pages, but Executor section still shows up on the left nav.
- Can we move the
Directed execution model (beta)page to be right afterIntroduction to primitives? It's also an intro/overview page that seems weird to be at the bottom.
Co-authored-by: Jessie Yu <jessieyu@us.ibm.com>
jyu00
reviewed
Apr 24, 2026
Co-authored-by: Jessie Yu <jessieyu@us.ibm.com>
6 tasks
jyu00
previously approved these changes
Apr 27, 2026
Collaborator
Author
|
Collaborator
Author
I reran it and don't see the warnings now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses part of #4613
Executor changes have been moved to #5028
Changes are extensive. Files to review follow:
Files with totally new content:
The rest of the changes are:
You can probably just ignore the files with changes of the third type, but you're welcome to review and commend on all 127 changed files if you so desire :)