[codex] Add duplicate submission URL validation#1101
Draft
TSS99 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
011so duplicate submission URLs are flaggedRoot cause
Check
011already existed inresources/checks.toml, but it had no checker attached, so repeated submission URLs were never enforced. On top of that, the URL collector inecosystem/validation/test_url.pyonly looked at shallow top-level fields, which meant package and PyPI URLs were skipped entirely.Fix
ecosystem/validation/test_url.pymember.pypi.*.urlin check011metadataTests
python -m pytest tests/test_validation_url.py -qpython -m pylint ecosystem/validation/test_url.py tests/test_validation_url.pypython -m black --check ecosystem/validation/test_url.py tests/test_validation_url.pyvalidate_member()sanity check showing the duplicate-URL case fails ontest_url.py::TestURLs::test_duplicate_urlswhile a distinct-URL case passes cleanlyNotes or limitations
tests/test_check.pycurrently has a syntax error onmain, unrelated to this patch.requestsdependency warning about the installedurllib3/chardetcombination, but it did not affect the checks above.Fixes #1087