Skip to content

Increase PyPI data coverage#1138

Merged
1ucian0 merged 8 commits into
Qiskit:mainfrom
neuralsorcerer:pypi
May 13, 2026
Merged

Increase PyPI data coverage#1138
1ucian0 merged 8 commits into
Qiskit:mainfrom
neuralsorcerer:pypi

Conversation

@neuralsorcerer
Copy link
Copy Markdown
Contributor

@neuralsorcerer neuralsorcerer commented May 10, 2026 •
edited
Loading

Summary

Details and comments

  • Added focused PyPIData unit coverage for package-name canonicalization, serialization, PyPI URL parsing, update/fetch behavior, JSON alias lookup, and release-date handling.
  • Added Qiskit dependency/compatibility coverage, including requires_dist parsing, empty specifier coercion, v1/v2 compatibility, highest supported Qiskit release selection, and no-match behavior.
  • Added cache and stats coverage for Qiskit release cache reads/writes/misses/errors, PyPIStats aggregation/404/error behavior, and download-property fallbacks.
  • Coverage increased for ecosystem/pypi.py to 100%

@1ucian0 1ucian0 self-assigned this May 12, 2026
1ucian0
1ucian0 reviewed May 12, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@1ucian0 1ucian0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work! Thanks!

Just few comments here and there.

Comment thread tests/test_pypi.py Outdated
Comment thread tests/test_pypi.py Outdated
Comment thread tests/test_pypi.py Outdated
Comment thread tests/test_pypi.py Outdated
Comment thread tests/test_pypi.py Outdated
Comment thread tests/test_pypi.py
Comment thread tests/test_pypi.py Outdated
@neuralsorcerer neuralsorcerer requested a review from 1ucian0 May 12, 2026 13:36
1ucian0
1ucian0 reviewed May 13, 2026
View reviewed changes
Comment thread tests/test_cli.py Outdated
1ucian0
1ucian0 reviewed May 13, 2026
View reviewed changes
Comment thread tests/test_pypi.py Outdated
@neuralsorcerer @1ucian0
Update tests/test_pypi.py
9f644eb 
Co-authored-by: Luciano Bello <766693+1ucian0@users.noreply.github.com>
1ucian0
1ucian0 reviewed May 13, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@1ucian0 1ucian0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are more points where mocking should be implemented instead of hooking into internals.

Comment thread tests/test_pypi.py Outdated
Comment thread tests/test_pypi.py Outdated
Comment thread tests/test_pypi.py Outdated
Comment thread tests/test_pypi.py Outdated
Comment thread tests/test_pypi.py Outdated
Comment thread tests/test_pypi.py Outdated
Comment thread tests/test_pypi.py Outdated
Comment thread tests/test_pypi.py Outdated
@neuralsorcerer neuralsorcerer requested a review from 1ucian0 May 13, 2026 12:06
1ucian0
1ucian0 approved these changes May 13, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@1ucian0 1ucian0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@1ucian0 1ucian0 added this pull request to the merge queue May 13, 2026
Merged via the queue into Qiskit:main with commit 2f56fc5 May 13, 2026
4 checks passed
@neuralsorcerer neuralsorcerer deleted the pypi branch May 13, 2026 15:24
@1ucian0 1ucian0 mentioned this pull request May 14, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1ucian0 1ucian0 1ucian0 approved these changes

Assignees

@1ucian0 1ucian0

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

increase test coverage of ecosystem/pypi.py

2 participants

@neuralsorcerer @1ucian0