This repository was archived by the owner on Aug 14, 2024. It is now read-only.
Reorganize Red Queen into a python package#21
Merged
Conversation
This commit reorganize the red queen project into a python project. Previously red queen wasn't organized as a single package which caused potential issues when trying to run or interact between the packages. This commit changes the repository structure to move all the code into the red_queen package so it is all self contained. This also enables us to create a python package with setuptools which increases future flexibility by enabling us to publish console scripts which will be include when the package is built and installed.
Lementknight
approved these changes
Jul 22, 2022
Contributor
Lementknight
left a comment
Lementknight
left a comment
There was a problem hiding this comment.
I don't see any problems with the new structure, and I believe that your commits are ready to be pushed.
Contributor
|
Very well explained! The comments were very helpful. I also believe the commits are ready to be pushed. |
danielleodigie
approved these changes
Jul 22, 2022
Collaborator
danielleodigie
left a comment
danielleodigie
left a comment
There was a problem hiding this comment.
This makes sense, it's low-key cool to see how making a python package works, makes it less scary :0, but overall LGTM!
Contributor
|
I agree with Danielle. This is efficient and understandable. LGTM! |
keilydluna
approved these changes
Jul 22, 2022
raynelfss
approved these changes
Jul 25, 2022
Collaborator
raynelfss
left a comment
raynelfss
left a comment
There was a problem hiding this comment.
The new changes work as intended and the new structure makes it easier to install all dependencies by pip-installing the repository as a python module. Looks good to me!
Member
Author
|
Thanks for the review everyone! |
mtreinish
pushed a commit
that referenced
this pull request
Aug 12, 2022
…#37) * Fixed oversight in changed-benchmark action Forgot to add "/*.py" suffix to only accept python files. * Fixed bash syntax in action.yml file for changed-benchmark (#21) There was an error in the `action.yml` file that caused the files-changed condition to ignore any new python files. This was due to an error in string parsing that was returning an empty string in every case instead of returning the string without the `__init__.py` The error was fixed by making the `steps.changed-benchmarks.outputs.all_changed_and_modified_files` a string stored in a variable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit reorganize the red queen project into a python project.
Previously red queen wasn't organized as a single package which caused
potential issues when trying to run or interact between the packages.
This commit changes the repository structure to move all the code into
the red_queen package so it is all self contained. This also enables us
to create a python package with setuptools which increases future
flexibility by enabling us to publish console scripts which will be
include when the package is built and installed.