Conversation
ihincks
reviewed
Mar 6, 2026
Collaborator
ihincks
left a comment
ihincks
left a comment
There was a problem hiding this comment.
Thanks, @joshuasn ! This will be a nice feature, and is perhaps overdue.
Is InjectNoise actually handled in this PR? I wasn't able to see it.
I'm also not a fan of TraceBox, partly because of the length. I bet we can come up with a single word directive.
Co-authored-by: Ian Hincks <ian.hincks@gmail.com>
Co-authored-by: Ian Hincks <ian.hincks@gmail.com>
ihincks
reviewed
Mar 9, 2026
Collaborator
|
TY Josh, this is looking good. I like how you can easily make any annotation write to |
Co-authored-by: Ian Hincks <ian.hincks@gmail.com>
Co-authored-by: Ian Hincks <ian.hincks@gmail.com>
Co-authored-by: Ian Hincks <ian.hincks@gmail.com>
Co-authored-by: Ian Hincks <ian.hincks@gmail.com>
Co-authored-by: Ian Hincks <ian.hincks@gmail.com>
ihincks
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the
TraceBoxannotation. When present alongsideInjectNoise, adds trace information to the barriers when the box is built.Details and comments
AI: some Claude Opus 4.6.