[WIP] Add a function to make conditionals twirlable#68
Open
[WIP] Add a function to make conditionals twirlable#68
Conversation
Collaborator
|
I think we should put developing conditional support on hold until we've done some refactoring and strategizing to simplify the code base. I'm finding it increasingly difficult to reason about the build process. |
Collaborator
Author
I agree with the general idea, but this particular PR doesn't involve the build process. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
#27
#29
Summary
This WIP PR adds a function which analyzes conditionals, and (when possible) creates a twirlable form of them for both left\right dressing.
Details and comments
This conditional cannot be twirled:
Using the function we can find a twirlable form for left dressing:
The same should work for right dressing, but there is a bug marked by a TODO in the code.
Some things to think about: