Skip to content

Conversation

@RemiBonnet
Copy link
Member

Summary

  • Add Cluster Advanced Settings views
  • Fix layout with scroll for Navbar and Sidebar sticky
  • Add new token for border "invert"

Screenshots / Recordings

Screenshot 2026-01-05 at 16 20 38 Screenshot 2026-01-05 at 16 20 55

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

- Added a new component for managing advanced cluster settings, allowing users to view and edit settings with validation.
- Integrated form handling using react-hook-form for better state management and user experience.
- Included tests for the new advanced settings component to ensure functionality and reliability.
- Updated routing to accommodate the new advanced settings page and adjusted sidebar links accordingly.
- Enhanced UI components for better styling and consistency across the application.
@RemiBonnet
Copy link
Member Author

Qovery Preview

Qovery can create a Preview Environment for this PR.
To trigger its creation, please post a comment with one of the following command.

Command Blueprint environment
/qovery preview 15d69f24-9bc1-4a8d-80fe-d1bb1b2bcd00 New Navigation
/qovery preview {all|UUID1,UUID2,...} To preview multiple environments

This comment has been generated from Qovery AI 🤖.
Below, a word from its wisdom :

The backlog never ends, be at peace with it

@RemiBonnet RemiBonnet marked this pull request as ready for review January 5, 2026 15:22

dataFormatted = objectFlattener(dataFormatted)

Object.keys(dataFormatted).forEach((key) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RemiBonnet Could you maybe bring the comment from these lines ? 🙏
It helped me a bit understanding this odd logic 😅

// below is a hack to handle the weird way the payload behaves

@RemiBonnet RemiBonnet merged commit 71b1f7b into new-navigation Jan 5, 2026
1 check passed
@RemiBonnet RemiBonnet deleted the feat/cluster-advanced-settings branch January 5, 2026 16:52
RemiBonnet added a commit that referenced this pull request Jan 6, 2026
* feat(cluster): implement advanced settings for clusters

- Added a new component for managing advanced cluster settings, allowing users to view and edit settings with validation.
- Integrated form handling using react-hook-form for better state management and user experience.
- Included tests for the new advanced settings component to ensure functionality and reliability.
- Updated routing to accommodate the new advanced settings page and adjusted sidebar links accordingly.
- Enhanced UI components for better styling and consistency across the application.

* refactor(tests): simplify ClusterAdvancedSettings tests with wrapWithReactHookForm

* Add comment for complex advanced settings logic
@RemiBonnet RemiBonnet restored the feat/cluster-advanced-settings branch January 6, 2026 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants