feat(cluster): add general step in the creation flow #2303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Qovery can create a Preview Environment for this PR.
This comment has been generated from Qovery AI 🤖.
|
RemiBonnet
commented
Jan 14, 2026
| @@ -1,9 +0,0 @@ | |||
| export interface RouteLayoutOptions { | |||
Member
Author
There was a problem hiding this comment.
This one is useless and not used
rmnbrd
approved these changes
Jan 14, 2026
| }) | ||
| const sortedCredentials = credentials.sort((a, b) => a.name.localeCompare(b.name)) | ||
|
|
||
| const openCredentialsModal = (id?: string, onChange?: (e: string | string[]) => void) => { |
Contributor
There was a problem hiding this comment.
@RemiBonnet Could be nice to use useCallback here
| const navigationContext = useNavigationContext() | ||
| const activeTabId = useActiveTabId(navigationContext) | ||
| const needsFullWidth = useFullWidthLayout() | ||
| const hiddenLayout = useHiddenLayout() |
Contributor
There was a problem hiding this comment.
Suggested change
| const hiddenLayout = useHiddenLayout() | |
| const bypassLayout = useHiddenLayout() |
rmnbrd
pushed a commit
that referenced
this pull request
Jan 19, 2026
* feat(cluster): add general step in the creation flow * refactor(routes): clean up router configuration and remove unused onboarding routes * refactor: rename layout functions and add callback for credentials modal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Screenshots / Recordings
https://www.loom.com/share/9bc66c9925694f96a4f67729fa2294b5
Testing
yarn testoryarn test -u(if you need to regenerate snapshots)yarn formatyarn lintPR Checklist
.cursor/rules)feat(service): add new Terraform service) - required for semantic-release